This repository was archived by the owner on Dec 2, 2021. It is now read-only.
modified Vector v4 equality check#35
Open
adnanmuttaleb wants to merge 1 commit intofluentpython:masterfrom
adnanmuttaleb:master
Open
modified Vector v4 equality check#35adnanmuttaleb wants to merge 1 commit intofluentpython:masterfrom adnanmuttaleb:master
adnanmuttaleb wants to merge 1 commit intofluentpython:masterfrom
adnanmuttaleb:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to my understanding of hashing and equality, I tried to enhance the performance of equality checking by ensuring that
__eq__does not perform component based comparison only if vectors has the same hash values (if two hashes is different then the two vectors are definitely unequal). because if two vectors has same hash value then: